search

MrKinau / FishingBot

1.8 - 1.20.6 Fishing bot for Minecraft
GNU General Public License v3.0
321 stars 67 forks source link

Password HASHING !!!!! #170

Closed Izocel closed 2 years ago

Izocel commented 2 years ago

come on dude ;)

Also did you consider to launch multiple bot with the same config file ;)

MrKinau commented 2 years ago

A hash is irreversible. The password in the config needs to be used in later usages (although you want to re-enter it every time). Hasing is not useful. Whats been done in the mojang launcher is that the password is encrypted with a key. This can be done, but has almost no effect, because it needs be stored somewhere safe which is highly platform specific. The code is a mess. Starting multiple bots is not a planned features, but obv. you can start the whole application multiple times with the config set as a command line parameter.

Izocel commented 2 years ago

Yes thats true for the hash didn't think about the auto-start procedure...

And for multiple, i've starded a folder structure but could we pass user and pass as parameter with config file so i could have a slave.config file and a master.config file ?? :)

Izocel commented 2 years ago

image

MrKinau commented 2 years ago

This can be done with the docker setup, but it's not documented at all (currently). If you know how to use docker compose, you can simply clone the repo, build the container and set the options using the docker compose file or command line. Otherwise you may. If you have an accesstoken you can also set the account file with the accountfile command line parameter.

Izocel commented 2 years ago

Ok thanks i'll look at that if contuning like that is a pain but should do the job once i've run a couple tests ;)