MrKinau / FishingBot

1.8 - 1.20.6 Fishing bot for Minecraft
GNU General Public License v3.0
321 stars 67 forks source link

Add translations Taiwanese support #218

Closed Hoshino0881118 closed 10 months ago

MrKinau commented 10 months ago

Thanks for your contribution, I really appreciate it. Before I merge your changes into main: I've adjusted some of the code in order to let this work. Here are the notable changes:

  1. Changed the language enum namings to CHINESE_SIMPLIFIED and CHINESE_TRADITIONAL, as well as the Locale you added in order to let it select the correct language. I've also changed the file name of all language files in order to support all languages and not only languages described in ISO-639-1 (two digit language code)
  2. Added a display name for all languages, I chose Chinese Simplified for the already existing (formelly CHINESE) translations and Chinese Traditional for the translations you added (fb_zh_TW).

I commited those changes in a seperate branch Hoshino0881118-main. Please just comment here if those changes are okay for you (mostly the naming change, I'm not 100% sure if those language names are correct, I've just took them from Crowdin), and I'll merge this branch into main, which marks this PR as Merged and the language will be available in the next update.

Additionally I've added Chinese Traditional (zh_TW) to Crowdin, which simplifies the translation process for future translation strings. It will show your translations, once it's merged.

Hoshino0881118 commented 10 months ago

OK, thanks

MrKinau commented 10 months ago

Merged. For the README changes please open another PR, if you want to contribute them, but they should pass the Codacy style check https://app.codacy.com/gh/MrKinau/FishingBot/pullRequest?prid=12879526