search

MrKinau / FishingBot

1.8 - 1.20.6 Fishing bot for Minecraft
GNU General Public License v3.0
321 stars 67 forks source link

Fishing bot is slow, and could not detect system theme. #234

Open bertocaster opened 5 months ago

bertocaster commented 5 months ago

Login successful! [2024-03-16 23:29:47] [INFO ] Name: [2024-03-16 23:29:47] [INFO ] UUID: 9a7a36d4-7fda-4b2e-a2bd-9d9c19819fe5 [2024-03-16 23:29:48] [INFO ] I start to fish! [2024-03-16 23:29:48] [INFO ] [CHAT] FishingBot v2.11.1 - Starting fishing [2024-03-16 23:30:46] [WARNING] The bot is currently slow. Maybe he is stuck. Trying to restart! [2024-03-16 23:31:07] [SEVERE ] Could not detect system theme UnsupportedClassVersionError: com/jthemedetecor/OsThemeDetector has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0. Maybe using legacy java version? 1.8.0_401

MrKinau commented 5 months ago

Hey @bertocaster,

the OS theme detector is not working for Java 8, it requires at least Java 11 to run, but it should not be any problem. If the bot detects it's slow, it basically means it havent fished anything within one minute, which can have several reasons:

  1. Bot is not facing water, fishing bobber not on water surface.
  2. Bot fished an entity, the bobber got attached to an entity (e.g. item), which prevents it from catching fish.

The easiest way to diagnose whats wrong is to spectate the bot with another account.

bertocaster commented 5 months ago

Thank you for the quick response and for your work!

bertocaster commented 5 months ago

A quick update:

For the bot detecting it's slow, I am unable to check with another account, but I am confident that the player is facing the water and the bobber is on the water surface. There is also no entities in front of the player. I logged in, did not move and could fish without any problems. Fishing rod has full enchants which means I should be able to lure pretty quick.

FlickerSoul commented 1 week ago

I seem to have the same issue. The log displays "The bot is currently slow. Maybe he is stuck. Trying to restart!" even though I checked the player can catch fish before starting the bot. I also found that when I stop the bot and then go back to the game, I can see a "phantom" fish bobber on the water: I can still cast bobber so that the casted and "phantom" bobber are both on water, and after retracting the casted bobber, the "phantom" bobber is still on water. You can see the video below

https://github.com/user-attachments/assets/b4061763-8593-4999-95cb-a5df2cabbb47

I can switch to other tools to make the "phantom" bobber disappear. I can catch fish normally with or without the "phantom" bobber.

https://github.com/user-attachments/assets/13fbaaad-bee0-41fa-b1b1-e83c39c84cd3

I can provide logs if that's going to be helpful. Thanks!

MrKinau commented 1 week ago

That's looking really odd. Can you tell me, which server software you are using as well as the version it's on? As well as any modifications of it, which may interfere the fishing process. Does this happen all the time? What happens after the stucking fix detected it's slow? Doesn't it re-start fishing again? or is the bobber bugged as well after the stucking fix re-reels the rod?

FlickerSoul commented 11 hours ago

Thanks!

I'm on 1.21. The list of client mods I have 

AdvancedBackups-fabric-1.21-3.6.jar            fabric-api-0.102.1+1.21.1.jar                  jei-1.21-fabric-19.8.2.99.jar                  offers-hud-1.21-1.6.1.jar
Resourcify (1.21+-fabric)-1.4.0.jar            fabric-language-kotlin-1.11.0+kotlin.2.0.0.jar litematica-fabric-1.21-0.19.0.jar              sodium-fabric-0.5.11+mc1.21.jar
Xaeros_Minimap_24.3.0_Fabric_1.21.jar          iris-1.7.3+mc1.21.jar                          malilib-fabric-1.21-0.20.0.jar                 tweakeroo-fabric-1.21-0.20.999-sakura.24.jar
appleskin-fabric-mc1.21-3.0.5.jar              itemscroller-fabric-1.21-0.23.999-sakura.7.jar minihud-fabric-1.21-0.31.999-sakura.20.jar

The list of server mods on the server 

AdvancedBackups-fabric-1.21-3.6.jar    fabric-api-0.102.0+1.21.jar
carpet-extra-1.21-1.4.147.jar          fabric-carpet-1.21-1.4.147+v240613.jar
carpet-tis-addition-v1.62.0-mc1.21.jar servux-fabric-1.21.0-0.2.0.jar

From my limited testing by now, this situation doesn't happen all the time. It often stuck like in the video but sometimes it works after restarting the bot many times, without any clear pattern. When the bot detected it's slow, the bot retries (at least it says it retries), even though it usually never get out the slow situation. I haven't viewed from a third person view to see if the bot really restart fishing or placing bobber.

I will get back to you once I tested more :)