MrKinau / FishingBot

1.8 - 1.21 Fishing bot for Minecraft
GNU General Public License v3.0
322 stars 68 forks source link

Bot is synchronized data or something #24

Closed tienanhnguyen996 closed 4 years ago

tienanhnguyen996 commented 4 years ago

when i use 2 or 3 bot sometime they are sync data or something just 1 fishing and the others does not and they chat all the samething when the one fishing caught something. Sorry for my bad english. Btw where can i see the tutorial about making minecraft bot like this

tienanhnguyen996 commented 4 years ago

oh onemore thing when i kill the bot it still chat but it don't appear again even thought i close it and open again

MrKinau commented 4 years ago

Hello tienanhnguyen996,

thanks for your issue, I'll appreciate that you created it. First things first: While developing this bot I focussed on exact the same thing you mentioned. It should be possible to fish with multiple instances at the same time, but I've not tested it after the last releases. Can you please give me more details about it? Does it only happen if the bots fish at the same spot? Which MC-Version do you target? Do you use the latest release of the bot?

To your second issue: Yes, the bot does not know, how to handle a respawn. I think the best way to handle it is to add a config option were the respawn handle could be changed (i.E. Disconnect, Restart fishing (at respawn location), do nothing (just respawn and wait)). At startup the bot should automatically perform a revival (currently the bot is still in death screen. also if it reconnects. It wont click on respawn)

Last, but not least: You dont have to write the best english. Its enough if I understand everything you want to tell (Sometimes I also use Google translator, lol). There is no tutorial on how I built the bot and there also is no documentation about it (except some code comments, which are quite rare to find). As the bot is a basic MC-Client I oriented on different projects (in my case Torchbot) to create some new MC-Bot. As come MC-Packets changed and the code from Torchbot isnt the cleanest (in my eyes) I started again from scrap and implemented some parts from Torchbot. The biggest help was the documentation of the minecraft protocol wiki.vg. The've documented all of the packets at almost any version and apply many differented hints on how to create an very own client: here, helped with the authentication of MC-Clients: here and also have a list of known custom clients: here. All in all, everything you need is much experience in Java-Development.

At the end: I try to fix your problems, but currently running out of time, because for me it's currently exam period and I have to learn for it... After that I am trying to split the project a little bit into its main components and try to create a simple way to use this as a framework to create own bots. I also have started a mining bot, but don't have enough time to develop more than just the protocol updates to the latest versions.

tienanhnguyen996 commented 4 years ago

https://youtu.be/JXqPJLBBAHM Here the video about the issue i'm using 1.15.1 And the latest release

MrKinau commented 4 years ago

Oh well, indeed this is unwanted behaviour.

Thanks for recording this. After my exams I will take a close look at it. About next week.

MrKinau commented 4 years ago

Well, a little bit earlier. Hopefully everything fixed in the latest comment. re-create if you still have issues :)