search

MrKuip / JMeld

1 stars 0 forks source link

Enable vcs version control diff #1

Open albfan opened 2 years ago

albfan commented 2 years ago

I fixed it on my fork:

https://github.com/albfan/jmeld/issues/8

Captura de pantalla de 2021-11-14 11-18-41

I tried to follow exactly what is missing here, but the Fx migration and all that NewPanel makes it little difficult. I think Vcs is not migrated to Fx?

Let me know if you have it working or your blockers to try to contribute here

MrKuip commented 2 years ago

i'm slowly converting to fx

albfan commented 2 years ago

I mean it is not working for me on old implementation.

First thing I notice, was that bazaar supports git, so at the time I fork it picks the first availale Vcs implementation, but in your project it takes the last, so it should work.

Still doesn't work for me, so probably I need to look further. Just if you know a version where Vcs panel is working (as it is commented right now) let me know. If no, I can try to find what is different on my fork (there's some time since I work on that)