search

MrLetsplay2003 / ShittyAuthLauncher

A Minecraft launcher for using a custom (shitty) authentication server
8 stars 2 forks source link

Support for downloads mirrors #3

Closed ajh123 closed 2 years ago

ajh123 commented 2 years ago

This PR requires https://github.com/MrLetsplay2003/ShittyAuthPatcher/pull/1 to be merged / published first. This is a draft, as there needs some 'spicing up', e.g. better variable names and revert not needed changes.

This PR allows people to create, edit, delete and switch mirrors. All mirrors end up being saved in a mirrors.json file inside the launcher's data directory, not the game directory. Users can only delete / edit mirrors if they are custom (e.g. originally made by the user)

ajh123 commented 2 years ago

Apart from local repo in pom.xml what else should we do

@MrLetsplay2003, do you like this?

MrLetsplay2003 commented 2 years ago

I'll take a closer look at it tomorrow :+1:

ajh123 commented 2 years ago

Your suggestions should be done now.

I think the currently active mirror should also be saved, so it will be loaded again when restarting the launcher.

There might also be some weirdness because versions from one installation (which e.g. uses the Mojang mirror) may not be available on another mirror, but that's not too big of an issue right now I think.

Also if you already ran the installation shouldn't it's version already be downloaded?

MrLetsplay2003 commented 2 years ago

Your suggestions should be done now.

I think the currently active mirror should also be saved, so it will be loaded again when restarting the launcher. There might also be some weirdness because versions from one installation (which e.g. uses the Mojang mirror) may not be available on another mirror, but that's not too big of an issue right now I think.

Also if you already ran the installation shouldn't it's version already be downloaded?

That's true. In some edge cases you can probably still end up with a dropdown with nothing selected, but it's probably fine