search

MrLixm / AgXc

Fork of Troy.S AgX, a display rendering transform available via OCIO and more
92 stars 8 forks source link

[reshade] add support for scrgb framebuffer #26

Open startuga opened 8 months ago

startuga commented 8 months ago

The shader works well when the game is in hdr10 but not in scrgb

MrLixm commented 8 months ago

Hello, do you have any screenshot/documentation link on what you call "scrgb" ? Why is it not working ?

startuga commented 8 months ago

HDR10PQ disable shaders FarCry®6 2023-12-28 09ː58ː14

HDR10PQ FarCry®6 2023-12-28 09ː58ː17

HDR SCRGB FarCry®6 2023-12-28 10ː04ː34

HDR SCRGB FarCry®6 2023-12-28 10ː06ː02

Dead Space HDR Dead Space 2023-12-28 10ː36ː20 Dead Space 2023-12-28 10ː36ː22

MrLixm commented 8 months ago

Thanks. I am surprised the shader works with HDR at all. As of right now there is no option for output colorspace encoding, assuming a "sRGB - Display" (with a 2.2 power function) output. Also if the same as HDR enabled I don't know what is going on in the reshade side, like what is the encoding of the game visual input ?

Then what is scRGB ? Never heard of it before and looking at Wikipedia it looks like a weird standard with a mention of not being intended for actual display.

With all of that I am not sure I can do much for your request. I don't have an HDR monitor for testing the support of the shader with HDR.

startuga commented 8 months ago

If you're interested in hdr you can see the work of these two people

https://github.com/EndlesslyFlowering/ReShade_HDR_shaders https://github.com/Filoppi/PumboAutoHDR/ Thanks.