MrLixm / AgXc

Fork of Troy.S AgX, a display rendering transform available via OCIO and more
92 stars 8 forks source link

[obs] shader doesn't compile on Apple M1 Max #31

Open MrLixm opened 5 months ago

MrLixm commented 5 months ago

Issue reported by jackson hayes on Twitter.

initial error

1:06:34.668: Error compiling shader:
11:06:34.668: ERROR: 0:312: 'output' : Reserved word. 
11:06:34.668: ERROR: 0:312: 'output' : syntax error: syntax error
11:06:34.668: 
11:06:34.668: 
11:06:34.668: device_pixelshader_create (GL) failed
11:06:34.668: Pass (0) <> missing pixel shader!
11:06:34.668: [source_info.create] Loaded effect /Users/user/Documents/OBS/AgXc-main/obs/obs-script/AgX.hlsl
11:06:34.668: Effect compilation failed for /Users/user/Documents/OBS/AgXc-main/obs/obs-script/AgX.hlsl
11:06:34.668: 
11:06:34.668: Failed to create source 'AgX'!

a first fix has been issued in 245ed202f1f96a4d1098df8c80cec7c6581f0f2e

second error

After the above fix, a second new error can be observed

OBS 30.1.0 log file uploaded at 2024-03-24, 13:02:34
13:02:09.299: [AgXc][source_info.create] Loading effect /Users/user/Downloads/AgXc-main/obs/obs-script/AgX.hlsl
13:02:09.306: Error compiling shader:
13:02:09.306: ERROR: 0:709: '{' : syntax error: syntax error
13:02:09.306: 
13:02:09.306: 
13:02:09.306: device_pixelshader_create (GL) failed
13:02:09.306: Pass (0) <> missing pixel shader!
13:02:09.306: [AgXc][source_info.create] Effect compilation failed for /Users/user/Downloads/AgXc-main/obs/obs-script/AgX.hlsl

which is very vague and impossible to find what could be causing it if I can't reproduce on my side.

context

For the last error.

commit 3fac5fba29aa3b1547444cbe0c9972ea8536048a

13:02:08.598: CPU Name: Apple M1 Max
13:02:08.598: Physical Cores: 10, Logical Cores: 10
13:02:08.598: Physical Memory: 65536MB Total
13:02:08.598: Model Identifier: MacBookPro18,2
13:02:08.598: OS Name: macOS
13:02:08.598: OS Version: Version 14.4 (Build 23E214)
13:02:08.598: Rosetta translation used: false
13:02:08.598: Kernel Version: 23.4.0
13:02:08.599: hotkeys-cocoa: Using layout 'com.apple.keylayout.US'
13:02:08.599: Current Date/Time: 2024-03-24, 13:02:08
13:02:08.599: Browser Hardware Acceleration: true
13:02:08.599: Qt Version: 6.6.2 (runtime), 6.6.2 (compiled)
13:02:08.599: Portable mode: false
13:02:08.693: OBS 30.1.0 (mac)