[Hossam Amer] Sprint One Review Request

[GoogleCodeExporter]

The code for our project is available on the project trunk, Sheel M3aya 
project. You are added to the repository so you can check it out easily.. 

Here are the repos:

1- https://sheel-maayaa-server.googlecode.com/svn/trunk/
2- https://sheel-ma3aya.googlecode.com/svn/trunk/

Please review my tasks which are:

1. Converting the database from the normal play into siena module db to be 
deployed on GAE. Hence, rewriting the models and relations to be compatible 
with siena module.
2. Creating the insertConfirmation controller in Confirmation file in the DB 
side.
3. Creating the communication view and displaying the contact info of the user
4. Made a call button through our application
5. Made a sms button through our application

Original issue reported on code.google.com by hossam.a...@gmail.com on 24 Nov 2011 at 5:58

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Please find attached the *.apk file

Original comment by hossam.a...@gmail.com on 26 Nov 2011 at 12:55

Attachments:

• SheelMaayaa.apk

[GoogleCodeExporter]

Hossam I remember the dr. mentioning I don't review the db and server side. 
Till me the Client side tasks that are related to ur server and db tasks.

Original comment by Salma.7a...@gmail.com on 27 Nov 2011 at 9:27

[GoogleCodeExporter]

Yes ya Salma, you are right... I listed all my tasks, but you can just pick up 
the android ones to review ;)

Original comment by hossam.a...@gmail.com on 27 Nov 2011 at 10:05

[GoogleCodeExporter]

and here are my user stories:

- As a registered user, I should be able to send a semi-automated SMS for my 
matching registered user.

- As a system, I should send a confirmation pdf to both emails/ send SMS to 
both phones after they confirm the transaction.

- As a registered user, I should be able to view the contact info of my 
matching registered user to call him/her.

Original comment by hossam.a...@gmail.com on 27 Nov 2011 at 10:39

[GoogleCodeExporter]

I don't really get how am I going to test ur stories.
Can u write them in the form of steps, Ya3ny click wth 3alshn y7sal eh ans wht 
is the output I should expect.
Because according to what u wrote in the Please review point. All I have to 
test is find a button called Make a call and another Make a SMS. I have no idea 
wht is to expect after clicking on any of these buttons ??

Original comment by Salma.7a...@gmail.com on 27 Nov 2011 at 10:45

[GoogleCodeExporter]

The task tested wre as follows:
1) when ssnding on the send SMS button the application did display a template 
to be sent.
Comment on the display in the Template instead of writting Dear User1, this 
should be replaced by the name of the user I anm sending the msg to and the 
name of the sender should be written at the end of the msg.
2) The task of confirm action it did work and sent a mail 
to my email.
Note: the mail the confirmation msg was sent to was hardcoded meaning it didn't 
use the mail i typed while registering.
Comments the layout  was ambigous I there wasn't any indicator if the user I 
will exchange with has already confirmed and if the offer was already taken by 
soneone also it still appeared, I think that once thw offer isn't avalible for 
me to take it shouldn't appear in the list.

Last but not least personal opinion I think the details button needs to be 
replaced and it's menu should appear when clicking on the user in the list.

Original comment by Salma.7a...@gmail.com on 29 Nov 2011 at 4:28

• Changed state: Done

[GoogleCodeExporter]

Many thanks for your comments.

Just for the 2nd point.. it is not hardcoded.. it is just the hard-coded user 
that you log in with. I just changed this assumed user's e-mail to yours to be 
able to see the mail on your inbox.

However, for all the rest, I strongly agree with you :-)

Original comment by hossam.a...@gmail.com on 29 Nov 2011 at 4:50