MrMC / mrmc

MrMC Main Repository - By using this code you agree to follow the GPLv2 license.
http://forum.mrmc.tv
Other
186 stars 68 forks source link

Screensaver would always be active on enterForeground #2

Closed DanTheMan827 closed 8 years ago

DanTheMan827 commented 8 years ago

switching out of the app (intentional or accidental) and going back in with a video playing would enable the screensaver

DanTheMan827 commented 8 years ago

Never mind, found the forum thread... How do I go about testflighting?

MrMC commented 8 years ago

email support@mrmc.tv, need email that matches appleid

MrMC commented 8 years ago

yes/no/maybe ?

DanTheMan827 commented 8 years ago

I sent you a email and you already sent back a testflight code

MrMC commented 8 years ago

but does it show same behavior ?

DanTheMan827 commented 8 years ago

Oh, I misunderstood you...

I downloaded the testflight but I haven't gotten to actually testing it yet...

The issue was that if you went to the tvOS menu and then back in while a video was playing the screensaver timer would then be enabled again

The screensaver itself wouldn't be running but if you played the video for x amount of minutes it would activate as if the screensaver was never disabled

I'm not home right now but I'll check when I get back

MrMC commented 8 years ago

If you could, 1.1.0 release had a hole and I rewrote the handling to better match core behavior. The tvOS screensaver is a pain :) You can't activate it and you only know it activated by getting moved InActive but NOT into the background. Then getting out of it was a real trick :) I should get a prize for what I came up with.

DanTheMan827 commented 8 years ago

Very creative using a URL to get out of it... Kodi actually has a bug in it at this moment... Memphiz never bothered to change the URL to disable the screensaver from mrmc://

That and Info.plist never had a URL handler registered for kodi...

DanTheMan827 commented 8 years ago

So, I tested the new build and it doesn't have the same screensaver problem

MrMC commented 8 years ago

Yay ! :) so this PR can be closed as fixed in master.