search

MrMC / mrmc

MrMC Main Repository - By using this code you agree to follow the GPLv2 license.
http://forum.mrmc.tv
Other
186 stars 68 forks source link

jsonrpc websocket api header not handled case insensitive #74

Open L-Henke opened 3 years ago

L-Henke commented 3 years ago

I found a problem with the handling of headers in a websocket connection to the json-rpc API. I'm using Home Assistant to connect to the API of MrMC. A recent change in the used aiohttp library broke this connection, because aiohttp changed a header from Connection: Upgrade to Connection: upgrade. This is compliant to the RFC which states, that this variable should be treated case-insensitive.

Current versions of Kodi are working fine with the changed header, but if you connect to MrMC, the connection runs into a timeout.

The jsonrpc version of MrMC seems to be way behind the upstream Kodi version, but maybe it is possible to upgrade your version or change the parsing of the connection headers to be case-insensitive.

amet commented 3 years ago

should be fixed in the next version, we will push the TestFlight version with it soon.

what platform are you running MrMC on?

L-Henke commented 3 years ago

I'm running MrMC on an Apple TV 4K.