Packages with capital letters in their distname end up unpackable by `wheel unpack`

MrMino / wheelfile

🔪🧀 API for creating and inspecting Python .whl files (wheels)

MIT License

29 stars 5 forks source link

Packages with capital letters in their distname end up unpackable by `wheel unpack` #10

Open MrMino opened 3 years ago

MrMino commented 3 years ago

WheelFile._distinfo_path uses packaging.utils.canonicalize_name, which it shouldn't: it lower-cases the name in the .dist-info prefix, which makes the wheel unrecognizable to wheel unpack and pip:

Missing Django-3.2.5+myversion.dist-info/RECORD file

Found out during working on the snippet in #9.

MrMino commented 3 years ago

Actually, the way WheelFile does it right now is the spec-correct way. See https://discuss.python.org/t/clarify-naming-of-dist-info-directories/5565.

MrMino commented 3 years ago

Reported in pypa/wheel#411