search

MrMino / wheelfile

🔪🧀 API for creating and inspecting Python .whl files (wheels)
MIT License
29 stars 5 forks source link

Adding EntryPoint support to wheelfile #12

Closed e2thenegpii closed 1 year ago

e2thenegpii commented 3 years ago

I added a new object to parse and write entry_points.txt to a wheelfile.

I added an entry_points attribute to the WheelFile object. The entry_points attribute is an EntryPoints class which provides a set interface for importlib.metadata.EntryPoint objects. But it has a __str__method and a from_strmethod similarly to the other metadata type handlers.

Please take a look, I'm open to all feedback.

MrMino commented 3 years ago

Hi. Sorry for a late response.

First of all, thank you for the PR. I can see you've done quite meticulous work to ensure that the new class fits in style and assumptions to the old ones. That's great!

At first I thought I'd say that I'm not sure if I'd like to have entry-points.txt as another metadata file given via property. IIRC it's not standardized in any PEP. It's just a metadata file that setuptools & distutils know what to do with. It doesn't necessarily has to be related to the Wheel format itself (i.e. PEP-427).

Then I saw https://packaging.python.org/specifications/entry-points/, and it feels like this is part of the packaging standard PyPA stands behind, and so it probably should be part of the wheelfile too.

I'll review your code fully after I get back from vacation (~beginning of September), and make a release as soon as it will be ready to be merged. Unfortunately I have very little time right now, due to the work I have to do ~before I go off-grid for a week.

Thanks again, sorry you'll have to wait, and stay tuned.

MrMino commented 3 years ago

BTW I think your commits or your GH account has misconfigured email? They don't show up as made by you.

e2thenegpii commented 3 years ago

bump