search

MrNerdy42 / keywizard-legacy

A simple Minecraft mod that makes finding and fixing key conflicts easier.
https://www.curseforge.com/minecraft/mc-mods/keyboard-wizard
Other
5 stars 3 forks source link

Keyboard Wizard affecting Controls GUI #23

Closed ariosos closed 4 years ago

ariosos commented 4 years ago

When trying to bind a control to CTRL, SHIFT or ALT using the Controls GUI, the selection will remain on the button and take any other key that gets entered. I only have Keyboard Wizard added.

Steps to Reproduce: 1 - Create a new forge instance and only install Keyboard Wizard (v1.7.1) 2 - Go to Options->Controls. 3 - Select any keybinding and press CTRL, SHIFT, or ALT.

Result: The selection will remain until another key or mouse button is pressed.

image image

I know there is a work-around to set openFromControlsGui to False, but this happens when it's the only mod being used. (Unless Forge is overriding the controls GUI?)

fuzzyweapon commented 4 years ago

This is a minecraft bug.

MrNerdy42 commented 4 years ago

As much as I'd like to believe that, this is my mod's fault. I'll have to look into why in the world it's happening.

The way I override the controls gui is pretty janky, I basically copied the controls gui code line for line and added a button. It makes me cringe just typing it. I probably screwed something up in my duplicate of the controls gui.

MrNerdy42 commented 4 years ago

I should be using reflection to do this, duh. I really shouldn't slap things together on 3 hours of sleep and 8 cups of coffee. This will be fixed ASAP

MrNerdy42 commented 4 years ago

Done