search

MrNerdy42 / keywizard-legacy

A simple Minecraft mod that makes finding and fixing key conflicts easier.
https://www.curseforge.com/minecraft/mc-mods/keyboard-wizard
Other
5 stars 3 forks source link

Does not save #4

Closed torenne closed 5 years ago

torenne commented 6 years ago

It seems to me that the new key settings does not save, and have to be configured every time the game loads. Is it possible to add a "Save" button?

Adarcer commented 6 years ago

You need to open menu and go into controls and then just exit too save. I actually think this is good just in case you mess up badly :P

Brycey92 commented 5 years ago

This isn't a feature, this is a bug, and it causes unnecessary frustration with users of the mod. That being said, this issue is still present in 1.5.2 for MC 1.12.2.

DemonfangArun commented 5 years ago

Ran into this today. The default keybinding to access this mod conflicts with moreoverlays. I'm going to remove this from my pack because, as nice as it is, it's obvious this isn't getting fixed anytime soon.

MrNerdy42 commented 5 years ago

This is definitely a pretty serious issue. I'll look into it now that I finally have time to maintain this thing.

Brycey92 commented 5 years ago

This bug is still present in the latest release (1.5.3). @MrNerdy42, please reopen this issue.

MrNerdy42 commented 5 years ago

I tested this before releasing and again just before replying to you. I am unable to reproduce this behavior in version 1.5.3. May I see your mod list, and log files?

Brycey92 commented 5 years ago

Mod list: dir.txt

Logs: logs.zip The logs inside gz files are from the first run, where the keybinds were changed, and the changes persisted through the session. The logs in the root of the zip file are from the second run, where the keybinds had reverted to their previous values.

Launcher log, if you need it: techniclauncher_2019-01-14.log This contains the launcher log for both runs.

MrNerdy42 commented 5 years ago

Sorry I took two days to respond. Your problem is that Galaxy-Craft Lite is still using the beta (1.5.3-b1), the bug wasn't fixed until the full release of 1.5.3.

MrNerdy42 commented 5 years ago

I'll amend my last comment by saying that it looks like you are indeed running the full release (1.5.3), but I downloaded your modpack on Technic and experienced the same bug you did. When I looked at the version of keyboard wizard, it was the beta. I don't really know what to make of this.

Brycey92 commented 5 years ago

I'm actively making the next version of the pack, so I was trying to test the updated mods before I released the pack update.

Oddly enough, I just tried again with different keys, and they were saved this time. I'll let you know when I get the pack update out so you can test it.

MrNerdy42 commented 5 years ago

Perfect. In the meantime, I'll keep testing different combinations of mods and configs to see if I can recreate your issue.

Brycey92 commented 5 years ago

It may be useful to know that the keys I tried changing the first time (which didn't stick) involved unbinding the scene related keys from the numpad. In the second attempt, which did work, I think I was changing the keys for some mod's functions.

MrNerdy42 commented 5 years ago

Could you point me to the mod that does this? If not I can take a look at it next time have access to my dev environment.

Brycey92 commented 5 years ago

I think the scene keys were from vanilla Minecraft, but I don't remember which mod's keys I changed. Here's the modpack I'm using. I released the update for it tat I was talking about.

MrNerdy42 commented 5 years ago

Okay, I'm closing this issue. By scene keys I assume you mean these:

key_Scene1 start/pause:41
key_Scene2 start/pause:0
key_Scene3 start/pause:0
key_Scene reset:0

I am completely unable to reproduce the behavior you're seeing in 1.12.2-1.5.3. This is a video of these keys saving in the options.txt.

(As a side note I can't for the life of me figure out what these keys do or what mod they come from)