search

MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.28k stars 319 forks source link

No edit bookmark menu, when autohide_bookmarks_and_main_toolbars is active #183

Open Vintic opened 2 years ago

Vintic commented 2 years ago

Can't edit bookmark from FF context menu.

Steps to reproduce:

  1. open any page
  2. right click on page content
  3. Press star button Result: bookmark is added but, no bookmark edit window appear. (autohide_bookmarks_and_main_toolbars.css is activated)

Problem seems to be, because main toolbar is hidden at this moment

List of used css: @import url(chrome/button_effect_icon_glow.css); @import url(chrome/button_effect_scale_onclick.css); @import url(chrome/tab_close_button_always_on_hover.css); @import url(chrome/minimal_toolbarbuttons.css); @import url(chrome/autohide_bookmarks_and_main_toolbars.css ); @import url(chrome/multi-row_bookmarks.css); @import url(chrome/multi-row_tabs.css); @import url(chrome/tabs_fill_available_width.css);

MrOtherGuy commented 2 years ago

Yeah, that is true.

Fixing that would require that we don't hide the main toolbar completely. At first glance replacing 90deg in line 23 with 89.9deg seems to work - however I'm not sure if it introduces some bad behavior.

I would appreciate it if you could test that for a few days and report back. I'll gladly make the change to the style if it works without causing further trouble.

Vintic commented 2 years ago

Thanks, it works now. I'll write in a few days.

Vintic commented 2 years ago

Hah, very strange but scrolling doesnt work with this fix on any site like: youtube, google... It work for a few seconds when toolbar is not hidden

MrOtherGuy commented 2 years ago

Riiight.... It's not consistent (at least for me) but I can certainly reproduce the issue. That is some extremely weird behavior, definitely one of the weirdest I've ever seen. Unfortunatetly I don't think there's any way we can work around that without completely changing how the toolbars get hidden - and I don't think I want to do that just to get bookmarks popup to work.

Vintic commented 2 years ago

Yeah, not a big issue, thanks for a try. Bookmarking still works when you press a star from urlbar. Should we close the issue?

MrOtherGuy commented 2 years ago

Bookmarking should still work OK even from the context menu, correct? It just is unable to open the popup, but the bookmark should be created.

Anyhow, lets keep this open because it is a real issue - just not one I currently know good solution for.

Vintic commented 2 years ago

Correct