search

MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.31k stars 319 forks source link

autohide_bookmarks.toolbar.css issue #257

Open kenarsene opened 1 year ago

kenarsene commented 1 year ago

New firefox update v110 makes the bookmarks bar transparent, any fix?

Screenshot 2023-02-15 045831

kenarsene commented 1 year ago

The problem is background-color: transparent !important; deleted that and it's fine now.

MrOtherGuy commented 1 year ago

Yeah, so this happens because Firefox removed --toolbar-bgimage cuatom property that was used in bunch of toolbars as background. So now that it doesn't exist the background-image we use on bookmarks toolbar computes to "none" thus you see it transparent.

We can't really do what you did and just remove that background-color: transparent rule because that's only going to work if one uses a Firefox theme with opaque, solid color toolbars.

In b906186 I added a temporary workaround by providing a fallback for case where that variable is missing which should make things work. But it looks like that variable is indeed completely removed from Firefox codebase and we can simplify the background-image related properties a bit. But I'll do that later.

It might also be worth to keep this hotfix since it should also work on Firefox ESR 102 and then only simplify the styling when next ESR releases.