search

MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.19k stars 312 forks source link

non_floating_sharp_tabs.css Firefox 110 active tab still shows bottom line #261

Closed Dunedan closed 1 year ago

Dunedan commented 1 year ago

This is the same report as #258, but even though it got closed, I still encounter this bug.

Here is what a clean profile looks like for me with the latest version of non_floating_sharp_tabs.css enabled in Firefox 110:

firefox-110-active-tab-bottom

MrOtherGuy commented 1 year ago

One thing I can think of that would cause this is if you use Firefox default theme but have removed toolbar background-color like this:

:root{
  --toolbar-bgcolor: transparent !important;
}

Then there isn't any color covering the line. If you have not added such custom rule then maybe your distro version of Firefox is doing that. In such case you can potentially fix it by adding:

:root{
  --toolbar-bgcolor: #f1f2f3 !important;
}
Dunedan commented 1 year ago

That does indeed fix it.

I'm not sure why though, because as mentioned I did reproduce it with a clean profile where adding non_floating_sharp_tabs.css was the only non-default change.

I also haven't been able to reproduce the problem on a second device. Both devices have a nearly identical setup (Debian/unstable, KDE, ...). The only difference I can think of right now is that the affected device uses a HiDPI display while the unaffected one doesn't.

MrOtherGuy commented 1 year ago

One thing that may very well differ is if Firefox is provided via some package manager. The distro can do various modifications to Firefox version they distribute, perhaps to make the UI better match their views or OS theme or whatever.

Official Firefox builds you can get from Mozilla website shouldn't have this issue.

Dunedan commented 1 year ago

One thing that may very well differ is if Firefox is provided via some package manager. The distro can do various modifications to Firefox version they distribute, perhaps to make the UI better match their views or OS theme or whatever.

I've checked the patches Debian applies to Firefox and none of them applies such a change to the toolbar background color.

MrOtherGuy commented 1 year ago

Hmm, well I don't know then. Anyhow, you got your setup working so that's nice.