search

MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.19k stars 312 forks source link

How can you show the tab bar on fullscreen and not hide content? #266

Closed joshpetit closed 1 year ago

joshpetit commented 1 year ago

Hey! I'm using tabs_below_content and am wondering if it's possible to show the tabs even while in fullscreen. I modified the #TabsToolbar element and added z-index: 2 which makes the tabbar show up even while in fullscreen, but it causes content to be blocked, like in the image bellow:

image

Is there a way to make this work?

MrOtherGuy commented 1 year ago

You copy line 44 and replace line 47 with it, that should do it.

joshpetit commented 1 year ago

Oh wow you responded so quickly I didn't even see the message haha! Thanks a lot that worked!! Is this something that should be changed in the repository?

MrOtherGuy commented 1 year ago

Great!

Is this something that should be changed in the repository?

No, at least not for the style in question. The purpose of tabs_below_content.css is to reorder toolbars such that tabs are below content. It's purpose is not to "make tabs toolbar visible when on fullscreen"

Although now that you mention it, fullscreen mode does also have an option to show toolbars while in fullscreen mode. So actually yes, if that option is enabled then the current behavior is wrong and what you propose should be the correct behavior.

I have added support for showing toolbars in fullscreen option in 05ad86a - though Firefox needs to be restarted if you change the option.

joshpetit commented 1 year ago

Awesome!