MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.13k stars 310 forks source link

Menubar clipped by tabs on bottom code after updating from 111.0.1 to 114.0.1 #292

Closed iwnb closed 1 year ago

iwnb commented 1 year ago

On June 18, 2023 I updated from Firefox 111.0.1 to Firefox 114.0.1. When I launched Firefox after updating, the left end of the menubar (the topmost bar) was clipped as shown in the attached image. The short end of the story is that the problem was caused by a stylesheet tabbar.css imported into userChrome.css which contains the latest code from the following sources in the order listed. It makes no difference whether the stylesheet is imported first or later and removing the last two sections also makes no difference.

https://github.com/MrOtherGuy/firefox-csshacks/tree/master/chrome/tabs_on_bottom.css https://github.com/MrOtherGuy/firefox-csshacks/tree/master/chrome/tabs_on_bottom_menubar_on_top_patch.css https://github.com/MrOtherGuy/firefox-csshacks/tree/master/chrome/window_control_placeholder_support.css https://github.com/MrOtherGuy/firefox-csshacks/tree/master/chrome/linux_gtk_window_control_patch.css ztabbarcss

MrOtherGuy commented 1 year ago

Does your userChrome.css contain anything else in addition to those four styles? I.e. does the issue manifest if you only use those four styles?

iwnb commented 1 year ago

Yes. I tested everything else in userChrome.css and removed the import of all but one other stylesheet (which tweaks the tab bar). The menu bar returned to normal when I removed the first two of those styles. wotabbarcss

MrOtherGuy commented 1 year ago

The only real place where menubar height is specified should be lines 9-16 in tabs_on_bottom_menubar_on_top_patch.css

So it would look like you hit the first case, where native titlebar is enabled. In such case the style makes the menubar only 20px tall, but the text size you have seems to be too big for that. So, you can probably just make the value on line 11 also 29px - or any value that you like.

iwnb commented 1 year ago

Thanks. I believed I tried that but that has fixed it.