search

MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.13k stars 310 forks source link

curved_tabs.css: loading burst ignores tab corners #306

Open contextnerror opened 11 months ago

contextnerror commented 11 months ago

The colored burst on page load doesn't include the bottom corners of the tabs.

https://github.com/MrOtherGuy/firefox-csshacks/assets/54487525/5ec31b27-3f7e-44bd-9425-263ecfc92b68

MrOtherGuy commented 11 months ago

Yeah, that's true, but sadly I don't think there any good way to fix that.

contextnerror commented 11 months ago

I'm not sure how, but it seems like WaveFox has managed to pull it off. Though it also mutes the colors of the loading burst by default, among many other things. I've had to change the default burst color in this example.

https://github.com/MrOtherGuy/firefox-csshacks/assets/54487525/e02a06a1-418c-4975-8199-b2557ee2b832

This is with tab option 8 enabled.

MrOtherGuy commented 11 months ago

Right. Wavefox creates its tab shaping effect in totally different way than what we are doing - they use mask image at tab-background whereas we have a variable sized background-image. Both have some advantages and disadvantages, and I think it would be at least pretty difficult if not outright impossible to make tab bursting effect work correctly with the way we are using.

contextnerror commented 11 months ago

Makes sense. In that case this can probably be closed.

MrOtherGuy commented 11 months ago

I'll keep this open in case someone figures out a nice way to do this. This is a bug after all, I'm just saying it might be hard to fix.