Tabs below content not workin properly anymore on FF 119.0

[Sabrehammer]

Tabs are still there, but all white bar with invisible inactive tabs.

[MrOtherGuy]

Make sure you are using the latest version of that style. As far as I can tell, it work without issues in Firefox 119

[doychi]

I was using an old version of window_control_placeholder_support.css and needed to update it. After that, things were fixed.

[MrOtherGuy]

Alright cool, I'll close this then.

[Sabrehammer]

Nope, I added that .css file, but still not working, naked FF 119 only Tabs on bottom code in userCrome.css.

[MrOtherGuy]

Oh. Okay, sorry, I didn't notice it was a different person who replied it to be working.

Now that I look your screenshot more closely I have a feeling I know what's going wrong. It seems to me that you are trying to use tabs_on_bottom.css to make tabs appear below content. The purpose of tabs_on_bottom.css is to make tabs the bottom-most toolbar, if you want to move tabs below content then you can use tabs_below_content.css to do so. I just checked and that seems to work correctly in Firefox 119 with several different themes.

[Sabrehammer]

My bad, yes I meant tabs_below_content. I figured out what the problem is, I had to change this:

TabsToolbar{ background-color: var(--lwt-accent-color); }

to a fixed color instead of accent color. After this it looks fine again.

No clue about this coding shit as I only use Tabs below content and nothing else in my userCrome.css

Thanks

[MrOtherGuy]

I mean, I suppose it might end up transparent if you use some theme that specifically makes sets --lwt-accent-color to be transparent. I can't really do anything about that.

[Sabrehammer]

See above, figured that out a second ago Thanks again

[MrOtherGuy]

Nice. Btw. could you share what theme you are using? I could add that to the set of themes I test stuff with.

[Sabrehammer]

Sure, so I narrowed it down to two things, I'm on Windows 10 where I use the dark color Theme, Transparency on, (but that does not seem to make a difference on FF) In FF I am on System-Theme, never changed to anything else.

Now, when I use the light Theme on Windows, Tabs look right, and back to dark, the bar is gone. Switching the FF Theme from Sytem-Theme to any other Theme fixes it without me having to change the code.

[MrOtherGuy]

Okay, sweet. This is something that I actually can fix after all.

[MrOtherGuy]

Now with a change from a0070f7 tabs toolbar won't use customized background color when the default theme is being used and thus both dark and light variants of default theme should behave correctly.

Well, it still don't work if a theme explicitly sets the accent color to transparent but I suppose that's pretty unlikely to ever happen.