search

MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.05k stars 307 forks source link

autohide_tabstoolbar.css causing page content to move up and down during animation #355

Closed FreyrDev closed 3 months ago

FreyrDev commented 3 months ago

Updated to Firefox 124 and the page content has now started moving as the tab bar is appearing and disappearing. When the tab bar is fully visible the content is in the right place, it only gets messed up during the animation.

simplescreenrecorder-2024-04-10_19.02.43 (trimmed).webm

Firefox version 124.0.2 on Linux, using autohide_tabstoolbar, tabs_on_bottom, tab_separator_line, and floating_findbar_on_top.

MrOtherGuy commented 3 months ago

Seems that I cannot reproduce this issue with those styles on Firefox 124.0.2 on Fedora. The issue seen on video sounds a bit confusing because autohide_tabstoolbar.css doesn't add any animation, so I don't really see why you experience an animation in the first place.

FreyrDev commented 3 months ago

autohide_tabstoolbar has a couple of transition properties doesn't it? I'm just referring to it sliding in and out rather than suddenly appearing. If I change all the values in milliseconds to zero then the bug doesn't appear (It just results in the tab bar appearing and disappearing instantly instead of smoothly).

How does it look for you with just autohide_tabstoolbar and tabs_on_bottom?

MrOtherGuy commented 3 months ago

Yes, you are right - I don't know what I was thinking. There should indeed be an transition and that isn't working. New patch to autohide_tabstoolbar.css should fix that though.

FreyrDev commented 3 months ago

Yep confirmed that fixes it. Should've checked !important myself lol.