search

MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.05k stars 307 forks source link

window_control_placeholder_support.css has no window control buttons #356

Closed mia-gamedev closed 3 months ago

mia-gamedev commented 3 months ago

Since the last update to firefox window controls are missing image

mia-gamedev commented 3 months ago

adding 

#nav-bar{
  position: static !important;
}

in nav-bar fixes it; not sure why but breaks nav buttons

MrOtherGuy commented 3 months ago

What style do you use along with window_control_placeholder_support.css? Also, what OS do you have?

For reference, I tried with Firefox 124.0.2 with tabs_on_bottom.css on Windows 10 and it seems to work correctly.

mia-gamedev commented 3 months ago

I use your hide_tabs_toolbar.css running Win 10 124.0.2 (64-bit), so no tabs as I'm using sideberry. That issue also happens on my laptop running Win 11 with the same CSS and Version. I was digging through the css and this does fix it:

#titlebar {
  z-index: 9999 !important;
}
#nav-bar-customization-target{
  z-index: 9999 !important;
}
#PanelUI-button{
  z-index: 9999 !important;
}

My guess is that the navbar is above the titlebar so the window controls are hidden. Forcing titlebar to be infront with the z index makes the windowcontrols appear and clickable, but all navbar items unclickable. Pulling nav-bar-customization-target and PanelUI-button also infront makes everything clickable, but its extremly hacky.

MrOtherGuy commented 3 months ago

Are you sure your hide_tabs_toolbar.css is up to date? This issue kinda sounds like what would happen before patch df4462f5d98266012569768ed570db5aa080030b - see issue #331

mia-gamedev commented 3 months ago

ill try that ... yea it works now. I didn't expect it to be from the hide_tabs_toolbar.css