search

MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.19k stars 312 forks source link

Dragging a tab to the bottom row of the bookmark bar places it in the equivilent position on the top row. #397

Open Awsomonium opened 3 weeks ago

Awsomonium commented 3 weeks ago

I unfortunately don't remember what version this started in as I hadn't updated firefox for a bit (but within the last 3 months or so, so whatever versions came out within that time period.)

To be honest, I'm not sure if this is even an issue that should be directed here, but I figured I'd give it a shot in case you already know what's going on here.

I have 6 rows of bookmarks currently. Showing 3 rows at a time. (I also have some code in my userchrome.css that places the tab bar below the URL bar)

Repro Steps:

  1. I go to place a new bookmark on the bottom row of the Bookmark toolbar via clicking and dragging the tab.

  2. The the little blue indicator icon that pops up indicating where the new bookmark will be shows up, though instead of being near where my mouse is hovering, between two or at the end of existing bookmarks, it shows up at the top of the toolbar.

  3. If I release the mouse to drop the tab onto the bookmarks toolbar, ends up at the top of the toolbar wherever the icon was hovering.

Fro anyone having a similar issue, I did found a workaround. Dropping the tab onto the toolbar at the VERY bottom of it (I'm talking 1-3 pixels from the bottom) does put it in the correct place. But it can be finicky and hard to get right (lower the mouse DPI to be more accurate if possible.)

MrOtherGuy commented 3 weeks ago

I was aware of the dropmarker thingy to be in incorrect position, nothing we can do about that sadly, but I had thought that the position where the bookmark is actually created is correct. Apparently that isn't always the case and I was eventually able to reproduce the issue. I believe what's happening is that if you end up dropping the tab or link into the space between bookmarks (in the margin area), then Firefox will pick up location further above and the bookmark will likely end up in the first row. But, if you drop the tab "on top" of an existing bookmark (which is what I mostly do) then the bookmark is created where it should.

I don't know if there are some other cases that would trigger this bad behavior, but if we collapse the margin then it should at least improve the situation. I'll add a narrow invisible border instead because if we just collapse the margin then things look rather crowded.

defyreality commented 2 weeks ago

your idea to drop them onto existing bookmarks on the second (or further rows) does indeed place as expected. dropping them into the open row, boops them into the very first row. this idea is definitely an improvement over having to go into the bookmark manager and reorganize.