search

MrOtherGuy / firefox-csshacks

Collection of userstyles affecting the browser
Mozilla Public License 2.0
3.28k stars 319 forks source link

Not all bookmarks shown #51

Open Fireballcz opened 4 years ago

Fireballcz commented 4 years ago

Hello, I have clean install of 76.0.1. After the first import from HTML backup - everything seems to be OK. Now I close FF. Newly opened FF shows about 2/3 of all bookamrks. If I delete them and import repeatedly from HTML, everything is OK, of course, until the next FF start. Identical problem I have at three different computers. I tried to clean, delete part of them, no luck. The same problem. Any help? Thanks.

MrOtherGuy commented 4 years ago

As far as I know, this problem has existed for ages. It's not really a issue caused by CSS, the problem just never manifests without multi-row tabs (which is what I assume you are having trouble with) because normally Firefox shows such a few bookmarks that it never gets to a point where the bookmarks won't be show anymore - well, perhaps if you had some ridiculously wide screen then it might appear.

I tried to look into it some years ago but really couldn't find anything conclusive. But I have some guesses; it probably has something to do with session restore, thus the "cut-off" point is probably affected by how fast your session restore is. I believe back then I personally got to having about 200 bookmarks in the toolbar before the issue started to appear. I just now tried with 93 and there is no problem.

But if it is in fact affected by session restore somehow then you may try replacing the following selector in multi-row-bookmarks.css line 17:

#PlacesToolbarItems{

with this:

:root[sessionrestored] #PlacesToolbarItems{

And see if it has any effect.

maikroservice commented 4 years ago

unfortunately, that does not fix the issue for me. Its also weird since I have the same userChrome.css on my Mac and on this linux machine here and the mac works perfectly while on linux there are bookmarks missing after about 70 or so

MrOtherGuy commented 4 years ago

I'm pretty sure that this is literally impossible to fix with CSS, though I would be happy to be proven wrong.

But following the same idea as I mentioned earlier - another thing you could test is adding :root:not([sessionrestored]) #PlacesToolbarItems{ display: none !important } I'm pretty sure that it doesn't fix it either but chances are that it would reflow the contents after Firefox has started up.

maikroservice commented 4 years ago

O_O that worked... :100:

MrOtherGuy commented 4 years ago

Woah. Dang. Okay, umm would you test some things for me and then I can add that to the style.

  1. Check that everything works properly when you open a new window.
  2. While multiple windows are open, close Firefox and open it again. It should work without issues.
  3. Add any button to the bookmarks toolbar, and then try 1. and 2. again.
  1. and 2. must definitely work without issues. Even if 3. fails for some reason it doesn't matter IMO because who adds buttons there in multi-row mode - but I just want to know about it.

I would do this myself but I can't reproduce the problem in the first place with 300+ bookmarks in toolbar...

maikroservice commented 4 years ago

Unfortunately, I have to report back that it again does not work :D It worked between windows even after restarting, however as soon as I added another bookmark and restarted firefox everything was back to 96 bookmarks only.

I then tried to:

  1. remove the bookmark I added and restart firefox (to no avail)
  2. remove the line from my userChrome.css, save and restart firefox, then close it again, add the line again, save and restart firefox (still not fixing it)

So it worked once but does not work anymore. Weird

MrOtherGuy commented 4 years ago

Well, that's unfortunate to say the least.

Fireballcz commented 4 years ago

Maybe it has something to do with 1) number of rows 2) screen resolution

ad 2. In fulscreen QWHD resolution it seems, the original code works OK. Yes there are some problems as dragging to another position or so, but for my needs works good. The problem occured in FHD resolutions - when bookmarks were exported from QWHD comp and imported to FHD comps.

Retruned back to previously functional multirow of FF v.73: 3xWQHD = OK, 1xFHD = BAD. Both cases the same clean install (including registry cleaning etc.), imported the same HTML bookmarks export.

I made another test with v.73: Deskopt = 3xWQHD = fully working. Moving the complete profile content to fresh install in laptop 1xFHD= identical bad result.