search

MrPeterJin / ASlide

An integrated Pathology Image (a.k.a. Whole-slide image) reading library.
10 stars 0 forks source link

Many bugs/API design issues report. #5

Open LuZWCHA opened 3 months ago

LuZWCHA commented 3 months ago
  1. Inconsistent definitions of method parameters of kfb_slide and openslide abstract_slide (parent class) of the read_region(location, level, size) method. In openslide default definiton, the first param location of the read_region allways represents the location of the region on level-zero, but we test the code on kfb slide and find that the location is related to the second param level that the location actually depend on level-{level} (not level-zero).
  2. Sdpc format slide .so (lib) not support some functions. We find at least the get_thumbnail(size) (this function is in this project), but the sdk (.so) does not have this function but defined get_thumbnail(thumb_level) (note the parameter has not the same meaning).
MrPeterJin commented 1 month ago

Hi there!

Many thanks for your valuable comments, we have indeed noticed these issues. This project is essentially a compilation of various APIs collected from the internet. Currently, I am quite busy with my PhD studies and don't have the time to make fixes. If anyone is willing to contribute, we welcome pull requests!