search

MrPig91 / PSChiaPlotter

A repo for powershell module that helps Chia Plotting
MIT License
181 stars 47 forks source link

Cosmetics #113

Open Jacek-ghub opened 3 years ago

Jacek-ghub commented 3 years ago

Hi,

Just potential small modifications to make the UI more consistent, and easier to read.

  1. Why we have "Run Time" but "TempSize" - one separates words with a space (rather normal), the other looks like is just verbalizing a variable. Also (just for this example), "temp" and "tmp" are interchangeable, so maybe it should be the shorter one?
  2. Time format. I would argue that most of the users are on engineering side, so why not to use HH:MM:SS time format? It is faster to read, easier to compare, shorter to display.
  3. Tab order in New Jobs / Paths section. If there is more than one drive/path given, there is no way to tab between those selections. For people that are more keyboard bound (than mouse), that is a bummer.
  4. On New Jobs dialog, should it be "Job Names" or rather singular "Job Name"? "Saved Jobs" is a drop-down, so plural is justified. However, on this one maybe not, as we are talking about that one particular job.
  5. For "New Job" dialog, the main focus is the job that we are creating/modifying. Is there a need to have at the bottom "Save Job" or "Start Job?" If there is such a need, should it also be "Cancel Job?"
  6. Can drives in Plotting and Farming Drives section be sorted?
  7. In Queued Jobs section, can Start Time be added to both Completed and Failed Runs tabs?
  8. In Queued Jobs / Completed Runs, can "Check Plot" be run automatically (maybe a checkbox on New Job?), and the line "Proofs 33 / 30, 1.1" be added to that table (still keep the button). Actually, I would also like to see a behavior change on that button - instead of just running the test, giving an option to provide starting point and check count (so, all plots will get tested right away, and only those with low scores (identified in red?) could be further tested using this button.

Thank you, Jacek

MrPig91 commented 3 years ago

I will take this into considerations, thank you! I am still working on core functionality at the moment.

lincolnthalles commented 3 years ago

I will take this into considerations, thank you! I am still working on core functionality at the moment.

regarding time format, this should get the job done: 

[TimeSpan]::FromHours($decimalHours).ToString("hh\:mm\:ss")