Improvement/misc

[phpfrog]

- Added Get-Help for "_Get-ChiaKPlotCombination_"
- Added "upto" param to filter kplots by largest kplot size for combinations.
- Added "c" as swtich to clear screen before displaying info.
- 

Please let me know if there's a standard process or a method to make it easier and/or more efficient for you. I'd like to help where I can, but I don't want to cause you to waste time unnecessarily, so if what I contribute isn't helpful in the scope of your vision then please let me know.

Feel free to reach out anytime (phpfrog@gmail.com).

[phpfrog]

Sure thing. The string was just to allow with or without the 'k'. I'd rather do it the way you prefer. I'll add the validate range and change it to 'int'.

On Thu, Jun 24, 2021 at 10:29 PM Syrius Cleveland @.***> wrote:

@MrPig91 commented on this pull request.

In PSChiaPlotter/Public/Get-ChiaKPlotCombination.ps1 https://github.com/MrPig91/PSChiaPlotter/pull/129#discussion_r658465728:

 [CmdletBinding(DefaultParameterSetName = "DriveLetter")]

param( [Parameter(ParameterSetName="FreeSpace")] [int64[]]$FreeSpace, [Parameter(ParameterSetName="DriveLetter")]

• [string[]]$DriveLetter = (Get-Volume).DriveLetter
• [string[]]$DriveLetter = (Get-Volume).DriveLetter,
• [string]$UpTo = "K35",

Can we do a validate range for this parameter? I think it will ensure proper values get inputted. [ValidateRange(32,35)] [int]$UpTo = 35

If you want to keep it as a string with the letter K, perhaps we can [ValidateSet("K32","K33"...)]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MrPig91/PSChiaPlotter/pull/129#pullrequestreview-692439698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANNDQ7NRPDJOJPUVH6DP5LTUQA3BANCNFSM47I34UPQ .

[phpfrog]

You're right. Stupid move on my part, sorry about that. I'll be sure to re-add it with the fix.

On Thu, Jun 24, 2021 at 10:31 PM Syrius Cleveland @.***> wrote:

@MrPig91 commented on this pull request.

In PSChiaPlotter/Public/Get-ChiaKPlotCombination.ps1 https://github.com/MrPig91/PSChiaPlotter/pull/129#discussion_r658466220:

 if ($PSCmdlet.ParameterSetName -eq "FreeSpace"){

foreach ($space in $FreeSpace){ $Max = Get-MaxKSize -TotalBytes $space

• $AllCombos = Get-OptimizedKSizePlotNumbers $Max | sort RemainingBytes
• $AllCombos = Get-OptimizedKSizePlotNumbers -MaximizedKSize $Max -KSFilter $KSFilter | Sort-Object RemainingBytes

I think we are missing the updated "Get-OptimizedKSizePlotNumbers" with the parameter -KSFilter. I think that must be a new parameter you created, but have not yet included in this Pull Request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MrPig91/PSChiaPlotter/pull/129#pullrequestreview-692440187, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANNDQ52GA2YRCXUNMM2DMDTUQBBTANCNFSM47I34UPQ .