feat: NOTICE-binary file

MrPowers / chispa

PySpark test helper methods with beautiful error messages

https://mrpowers.github.io/chispa/

MIT License

595 stars 65 forks source link

feat: NOTICE-binary file #128

Closed SemyonSinchenko closed 2 months ago

SemyonSinchenko commented 2 months ago

PR Checklist

[x] A description of the changes is added to the description of this PR.
[x] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added or modified a feature, documentation in docs is updated

Description of changes

We need to follow licenses of our dependencies little more strictly. I'm not 100% sure how to do it, but I think adding NOTICE-binary is a good first step.

Close #116

SemyonSinchenko commented 2 months ago

@fpgmaas Do you have an idea, how can we include this file into an output python package? Based on my knowledge, we must distribute it with the chispa itself.

fpgmaas commented 2 months ago

@fpgmaas Do you have an idea, how can we include this file into an output python package? Based on my knowledge, we must distribute it with the chispa itself.

@SemyonSinchenko I think we can use Poetry's include, I did something similar here

fpgmaas commented 2 months ago

@SemyonSinchenko I don't think we need this though, right? We don't distribute a copy of these packages ourselves. We just mention that our package needs these packages. These are then installed by the user from PyPI, and that includes the license. Do you know any other big OS projects that do this?

SemyonSinchenko commented 2 months ago

@SemyonSinchenko I don't think we need this though, right? We don't distribute a copy of these packages ourselves. We just mention that our package needs these packages. These are then installed by the user from PyPI, and that includes the license. Do you know any other big OS projects that do this?

I do not know to be honest... You are right, let's leave it as is, just a NOTICE file.