Open calum-mcg opened 1 year ago
@MrPowers - please let me know if this meets the requirements
Once this is merged, I'll work on the refactor ticket
Just bumping @MrPowers
any movement on this one @MrPowers? This will be a really good addition beyond the original issue as will very useful for accessibility reasons too.
@MrPowers
This is great, thanks for the contribution.
From a user perspective, I think they'll want to set the colors globally and not have to set this manually for every test.
Setting underline_cells=True
and then seperately setting "underlined":"purple"
in the color_scheme
seems off.
We have a few things we're tracking now:
The underline_cells
option is poorly named. If we're giving the user full configuration options, then they should be able to underline whatever they want (including matched rows or matched cells).
I am going to have to think about this one some more. We should give the user good defaults, a reasonable mechanism to set global overrides, and the flexibility to set test-level settings.
Created an issue to discuss this at a higher level: https://github.com/MrPowers/chispa/issues/75
Description
Added an option to provide a color scheme for font when comparing dataframes. Example:
Usage:
The default color scheme (if none provided):
List of available colors in the bcolors class.
In addition, I've added two checks to validate the color scheme dict:
bcolors
classFixes #66
Type of change
How Has This Been Tested?
poetry run pytest tests
)