MrPowers / chispa

PySpark test helper methods with beautiful error messages
https://mrpowers.github.io/chispa/
MIT License
595 stars 65 forks source link

Drop support for Python 3.7 and Pyspark 2.x and remove vendored dependency on six #80

Closed fpgmaas closed 2 months ago

fpgmaas commented 11 months ago

This PR:

For removing the dependency on six, I simply replaced six.moves.zip_longest with itertools.zip_longest as suggested by @MrPowers. I however did not test if this changes existing functionality, I assume that is already covered by the unit tests? Those ran uccessfully.

See also https://github.com/MrPowers/chispa/issues/78

fpgmaas commented 2 months ago

@MrPowers I think this one is ready for review; is it time to drop support for Python 3.7 and pyspark 2.x? If not I can reset that part and we'll leave that for another PR. I realize that this PR can be considered to do a bit too much, so no problem if you prefer to split that up.

fpgmaas commented 2 months ago

@SemyonSinchenko Do you have time to review this one by any chance? I based a few other PR's on top of this one. (https://github.com/MrPowers/chispa/pull/81 and https://github.com/MrPowers/chispa/pull/106), so if this is merged I can rebase those.

SemyonSinchenko commented 2 months ago

@fpgmaas I can, of course, but I do not have write access here. @MrPowers