search

MrPowers / mack

Delta Lake helper methods in PySpark
https://mrpowers.github.io/mack/
MIT License
286 stars 42 forks source link

Create Pull Request Template #92

Open robertkossendey opened 1 year ago

robertkossendey commented 1 year ago

We should create a template for pull requests, requiring the contributor to tick a box stating that he read the contributing guidelines (CONTRIBUTING.md). By that we can make sure that the contributor has run the pre-commit hooks on his machine (flake8, black and pytest).

MrPowers commented 1 year ago

Yes, I like this idea, thank you for making this suggestion. Would be great for someone to grab this.

robertkossendey commented 1 year ago

@MrPowers we should also add an Issue Template with "I would like to contribute" checks as well. More and more people are opening issues / contributing, so this will come in handy.

MrPowers commented 1 year ago

@robertkossendey - yea, an issue template with "I would like to contribute" would be great as well. Good idea!

Triamus commented 1 year ago

Would be great if pure documentation commits don't require pre-commit setup as it may scare off folks who otherwise have valuable contributions. Can you exclude changes to the README.md from pre-commit hooks requirement by default somehow?

paulooctavio commented 1 month ago

@robertkossendey Can I take this one? It will be my first issue, so I might just need a little guidance.