removing flake8 in favor of ruff

MrPowers / mack

Delta Lake helper methods in PySpark

https://mrpowers.github.io/mack/

MIT License

286 stars 42 forks source link

removing flake8 in favor of ruff #98

Closed danielbeach closed 1 year ago

danielbeach commented 1 year ago

Remove flake8 and replace it with ruff.

change the git workflow to use ruff
add ruff to the pre-commit hooks
add ruff to the pyproject.toml

robertkossendey commented 1 year ago

Could we also change the badge in the README? Otherwise great PR, thank you very much!

danielbeach commented 1 year ago

@MrPowers @robertkossendey I checked the flake8 config https://github.com/MrPowers/mack/blob/main/.github/workflows/flake8.yml and it appears the line-length was about the only "custom" config I could find, which I migrated to flake8. Let me know if there's anything else we should add.

robertkossendey commented 1 year ago

@danielbeach great, thank you! I think we should have a separate discussion of what kind of rules we want to introduce, so this should be fine!

cc: @MrPowers

MrPowers commented 1 year ago

@danielbeach - PR looks great. Think we just need to make ruff a dev-dependency. That way users don't get ruff installed as a transitive dependency when they run pip install mack. Really excited about this!

MrPowers commented 1 year ago

Thanks for adding this. Merging now. Fingers crossed it all works!

MrPowers commented 1 year ago

@danielbeach - BTW, pro tip (aka pro hack) for Poetry. Whenever you're dealing with annoying poetry.lock issues because you changed the pypoetry.toml file, just run rm poetry.lock and then regenerate it with poetry install. It's so annoying haha, but that's the best way I've found.