search

MrPowers / quinn

pyspark methods to enhance developer productivity 📣 👯 🎉
https://mrpowers.github.io/quinn/
Apache License 2.0
597 stars 93 forks source link

fix ruff lint #189

Closed jeffbrennan closed 4 months ago

jeffbrennan commented 5 months ago

@MrPowers this should get rid of the scary x

changes to split_columns.py shouldn't affect anything not familiar with the row.get() method in schema_helpers.py but the tests cover mode="permissive" cases and they pass for me

jeffbrennan commented 5 months ago

updated pyproject.toml after doing some investigation and reading #187

image
SemyonSinchenko commented 5 months ago

I'm afraid that they may introduce new rules in updates, and we will face cases when we start getting failing lint on old codebase one day

jeffbrennan commented 5 months ago

Yeah that makes sense, in that case we should specify a ruff version in the ci setup

SemyonSinchenko commented 4 months ago

@jeffbrennan Is it ready for merging?

jeffbrennan commented 4 months ago

@SemyonSinchenko

there's been a lot of changes to the main repo since these changes. I'll close this PR and look at setting a ruff version in CI. If there's still formatting issues afterwards I'll take care of those