BUG: Code cleanup - Githubissues

MrPowers / quinn

pyspark methods to enhance developer productivity 📣 👯 🎉

https://mrpowers.github.io/quinn/

Apache License 2.0

597 stars 93 forks source link

BUG: Code cleanup #220

Closed kunaljubce closed 3 months ago

kunaljubce commented 4 months ago

Quinn version checks

[X] I have checked that this issue has not already been reported.
[X] I have confirmed this bug exists on the latest version of quinn.
[X] I have confirmed this bug exists on the main branch of quinn.

Reproducible Example

This is not a breaking issue, so there's nothing to be reproduced. This issue is an attempt to clean up apparently dead code.

Issue Description

In the https://github.com/MrPowers/quinn/blob/main/tests/test_transformations.py file, we see a lot of redundant nested column definitions that seem to serve no purpose except for code redundancy.

E.g. https://github.com/MrPowers/quinn/blob/4157a3c07ed2b7dbb9696678ff87a3273b7dc092/tests/test_transformations.py#L20 https://github.com/MrPowers/quinn/blob/4157a3c07ed2b7dbb9696678ff87a3273b7dc092/tests/test_transformations.py#L43 https://github.com/MrPowers/quinn/blob/4157a3c07ed2b7dbb9696678ff87a3273b7dc092/tests/test_transformations.py#L68 https://github.com/MrPowers/quinn/blob/4157a3c07ed2b7dbb9696678ff87a3273b7dc092/tests/test_transformations.py#L100

Expected Behavior

We can remove all these function definitions and have them in the body of the original function itself.

Installed Versions

0.10.2

kunaljubce commented 3 months ago

Closing this as this is a non-issue. This kind of declarative syntax is called pytest describe syntax - https://github.com/pytest-dev/pytest-describe