MrPrimate / NoteLicker

A simple auto note pin app for FoundryVTT
MIT License
1 stars 1 forks source link

Updating Note's Text Label Does Not Update Icon Number #4

Open kiloforce opened 9 months ago

kiloforce commented 9 months ago

Describe the bug I update the Note's "Text Label", but it does not update the Note's icon number.

To Reproduce Steps to reproduce the behavior:

  1. Create a Journal Entry.
  2. Drag and Drop the Entry to the Canvas
  3. Set the Note's Text Label to some Number
  4. Probably update the associated journal page title, which is why you are updating the note (optional)
  5. Edit said Note, and change Text Label and give a different number. It does not update the Note icon number.

Before: image

After: image image

Expected behavior Editing the Note's text label should update the Note's icon number.

Screenshots See above

Environment:

Additional context I did find a workaround, which doesn't require recreating the note... if you do the reverse, meaning update the note icon text, then update specifically the associated journal page's title (any change), that seems to trigger some internal update that does update the note's icon number? Can that somehow be used to fix this issue directly?

MrPrimate commented 9 months ago

This is a little more difficult as the icon is rendered when the system issues a draw command, which I don't think it does if say just the label is updated. I will have a think.