MrPrimate / ddb-importer

Integrate your dndbeyond.com content into Foundry virtual tabletop
MIT License
186 stars 72 forks source link

Classes and Features Munch missing items/features #147

Open MaxPat931 opened 3 years ago

MaxPat931 commented 3 years ago

Importing Class Features via the Munch is missing items that would be imported via character import, Active Effects also do not import

Individual items for Paladin's Channel Divinities - currently one item "Channel Divinity (Subclass) Channel Divinity (Paladin) Channel Divinity: Abjure Enemy Channel Divinity: Abjure the Extraplanar Channel Divinity: Champion Challenge Channel Divinity: Conquering Presence Channel Divinity: Control Undead Channel Divinity: Dreadful Aspect Channel Divinity: Emissary of Peace Channel Divinity: Fury of the Tides Channel Divinity: Inspiring Smite Channel Divinity: Marine Layer Channel Divinity: Nature's Wrath Channel Divinity: Peerless Athlete Channel Divinity: Rebuke the Violent Channel Divinity: Sacred Weapon Channel Divinity: Turn the Faithless Channel Divinity: Turn the Tide Channel Divinity: Turn the Unholy Channel Divinity: Turn Undead Channel Divinity: Watcher’s Will Channel Divinity: Vow of Enmity

Some Cleric Domain Spell features Domain Spells (Arcana Domain) Domain Spells (Death Domain) Domain Spells (Knowledge Domain) Domain Spells (Life Domain) Domain Spells (Light Domain) Domain Spells (Nature Domain) Domain Spells (Tempest Domain) Domain Spells (Trickery Domain) Domain Spells (War Domain)

Ranger Optional Feature Primal Companion

There are also several items imported that are listed as subclass options, but are class options (some examples): Extra Attack Fighting Style (Echo Knight) Spellcasting (Armorer) Timeless Body (Circle of Stars) Unarmored Defense (Path of the Berserker)

MrPrimate commented 3 years ago

Hi @MaxPat931 this is a current limitation of the way this is implemented currently and requires a large re-write to improve.

MrPrimate commented 3 years ago

I will also break this into 4 issues, as they are different bugs/enhancements to solve.

MaxPat931 commented 3 years ago

Yep, I figured that would be the case. I understand this feature isn't a priority right now, I just wanted to make note of my findings while I was working on it this past week.

MrPrimate commented 3 years ago

It's a very useful list, thanks!

MaxPat931 commented 2 years ago

Bonus Proficiencies have been included, some Domain Spells have been included, I've updated the initial comment to reflect that. Also removed the feature options (ki, invocations, etc) to create a new ticket