Incorrect URLs in a few books

[kakaroto]

While searching for incorrect URLs in the json files for #6, I noticed quite a few other incorrect URLs that can't be fixed without your input (i.e: not pointing to images from the DDB books or the assets ddb-meta-data folder). Here are a few examples I found (there might be more which are invalid URLs but don't have "assets" in the path, since that's what I was searching for) :

• https://github.com/MrPrimate/ddb-meta-data/blob/main/content/scene_info/idrotf/idrotf-10104-1073-MapMap61cavesofhunger-player-scene.json has all of its notes referencing paths of the form "ddb-images/adventures/misc/assets/icons/Hxx.svg"
• tfof book has a few notes referencing assets/icons/xx.svg as well as assets/adventures/misc/assets/icons/xx.svg (maps 22, 23, 24, 25 and 26)
• https://github.com/MrPrimate/ddb-meta-data/blob/main/content/scene_info/thsot/thsot-10004-386-Map31TheHiddenShrineofTamoachan-player-scene.json this is referencing multiple assets from an external AWS bucket https://bucket.eu-west-1.amazonaws.com/assets/adventures/misc/assets/icons/xx.svg which wouldn't work in an offline environment (and may also not be ok to use that bucket for this)
• https://github.com/MrPrimate/ddb-meta-data/blob/main/content/scene_info/twbtw/twbtw-10028-1440-Map23downfall-player-scene.json references assets/icons/Dxx.svg
• https://github.com/MrPrimate/ddb-meta-data/blob/main/content/scene_info/twbtw/twbtw-10063-1448-Map51palacelower-player-scene.json references a path under a worlds/ for one of its tokens (worlds/Forgotten-Realms/adventures/The_Wild_Beyond_the_Witchlight/assets/05-004.thinnings.webp)
• wdh book has a few files with references to ddb-images/adventures/misc/assets/icons/xx.svg

I am assuming the assets/icons/.. should be files available maybe under the metadata repo to be used for the scenes that need them, but the files aren't there. I don't know if those number circle icons are available in core foundry nowadays and can be used instead.

All the ddb-images/adventures/misc/assets/icons and the assets/adventures/misc/assets/icons/ should become assets/icons I assume, the external AWS bucket should also change to use the local files. Finally the path using a worlds/ path for the token is an obvious error which I think should just be removed. Can you confirm please and if you agree, can you upload the assets/icons folder to the repo ?

Thank you.

[MrPrimate]

SVG icons are generated by adventure muncher of ddb-importer - you'll need to duplicate the solution to generate your own. It replaces this path in the final run with it's own generated data.

The token image paths are not used by the ddb-importer when it merges data together, so the paths here are discarded right now.

[kakaroto]

Ah, thanks for that insight, that makes sense. I see you also fixed the AWS bucket links, thanks for quickly fixing it. I'd propose it to be standardized on assets/icons/ rather than sometimes being assets/icons and sometimes ddb-images/adventures/misc/assets/icons and sometimes assets/adventures/misc/assets/icons. I'd also propose using ddb://ddb-meta-data/ prefix for that (I don't know if you support that schema on your side or not yet).