MrPrimate / pathmuncher

Munch Pathfinder 2e characters into Foundry from Pathbuilder
MIT License
23 stars 6 forks source link

classDC rank gets set to untrained for level 1 character #13

Closed zajosk closed 1 year ago

zajosk commented 1 year ago

The imported level 1 character gets its classdc proficiency set to 0 untrained, which makes the classDC lower than intended

Steps to reproduce:

  1. create new level 1 character in pathbuilder, export json
  2. create fresh actor in foundry
  3. run pathmuncher with json id from pathbuilder, leave everything default
  4. classdc rank is 0. It should be 1 (can be seen in the debug console)

Expected behavior For a level 1 character, classdc rank should be 1 - trained

Environment:

MrPrimate commented 1 year ago

I'm not sure your right - not all classes are trained in Class DC's - wizards (from the example character you have provided) are not trained in a class DC. And characters such as the Fighter or Champion, which are, import with their class DC set correctly.

zajosk commented 1 year ago

I have raised the issue, because I was comparing outputs from pathbuilder with the output from foundry. Pathbuilder was reporting a higher classdc than foundry, that's how I found out. Also I double checked, that the json output from pathbuilder contained the same value for classdc as for other attributes (arcana etc) that were set correctly as trained.

But now that you mentioned it, https://2e.aonprd.com/ lists the fighter with a trained fighter class dc and the wizard does not have anything like that. So that basically means pathbuilder is wrong and somehow pathmuncher corrects the incorrectly provided data?

MrPrimate commented 1 year ago

Pathmuncher basically just ignores that bit of the JSON, as it's tracked by the Foundry class and feats update the value if a class feature increases it.