MrPrimate / pathmuncher

Munch Pathfinder 2e characters into Foundry from Pathbuilder
MIT License
23 stars 6 forks source link

Class and Background item references are removed on import #6

Closed Drental closed 1 year ago

Drental commented 1 year ago

Describe the bug after the import of a character the class item is missing all the normal references to the class's class features, and teh background is missing the reference ot the Background feat.

The Background Feat actually works, but the reference missing on the background is irritating to me. Changing the Background on the sheet correctly removes the Skill Feat.

To Reproduce Steps to reproduce the behavior:

  1. Import a character
  2. change the level to 0
  3. change the level to the correct level again

alternatively

  1. Import a character
  2. level up

Expected behavior Class Features get added on level ups and cen be refreshed with the level down -> level up method as on normal characters.

Screenshots image Summoner after Import image Summoner on a normal Character image Class features are empty and stay empty after changing levels.

Environment: Foundry Virtual Tabletop: Version 10, 10.291 Game System: pf2e, 4.8.3 Active Modules: 32 Performance Mode: 2

OS: Unknown Client: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36 GPU: ANGLE (Intel, Intel(R) UHD Graphics Direct3D11 vs_5_0 ps_5_0, D3D11) Max Texture Size: 16384

Scene: 1618 x 1080 | Grid Size: 100 | Padding Percentage: 0 Walls: 0 | Ambient Lights: 0 | Ambient Sounds: 0 | Tiles: 0 | Tokens: 2

Actors: 47 | Items: 16 | Journal: 130 | Rollable Tables: 0 | Playlists: 6 | Compendium Packs: 103 | Chat Messages: 2

Module Version 0.1.6 Does this behaviour occur with other modules disabled: Yes

Additional context Add any other context about the problem here.

Bonus issue. image logger.js:60 pathmuncher | ERR > Unable to match Greater Insistent Door Knocker {pbName: 'Greater Insistent Door Knocker', qty: 1, added: false}added: falsepbName: "Greater Insistent Door Knocker"qty: 1[[Prototype]]: Object log @ logger.js:60 error @ logger.js:83

generateEquipmentItems @ Pathmuncher.js:983

await in #generateEquipmentItems (async)

processEquipment @ Pathmuncher.js:1325

processCharacter @ Pathmuncher.js:1426

This may be on the system to fix, I'll get the ask in to change all the "x (greater)" to "greater x" - it can probably be handled by Pathmuncher too, but we have all the tools that we no longer need the parentheses in my biased opinion. somewhat fuzzy search rules!

MrPrimate commented 1 year ago

The missing references for classes and backgrounds etc should be fixed in v0.1.8 (out now) and I'll look at fixing up the Greater Insistent Door Knocker.

MrPrimate commented 1 year ago

Both issues now resolved as of v0.1.9