MrPrimate / tokenizer

Tiny yet capable in-game token editor for Foundry VTT
MIT License
28 stars 25 forks source link

Custom Frames Fail to Mask, Layers are completely Hidden while default frames work fine #132

Closed KellethDregar closed 10 months ago

KellethDregar commented 1 year ago

It seems this issue is occurring again: https://github.com/MrPrimate/tokenizer/issues/80

Token frames seem to not apply a mask layer and will obscure the entirety of the layer below. It seems to still be working with the last version 4.1.1

V 4.1.2 image

V 4.1.1 image

MrPrimate commented 1 year ago

Can you explain the process you're using to add a frame? Is this the default frame? Added via add image? Or via the add frame button?

KellethDregar commented 1 year ago

The above scenarios were both done with the "Upload from your computer" functionality. I tested with a variety of token borders, it seems any uploaded don't get properly masked. I tried with Ray Algorithm on and off to no avail.

When using one of the default frames under the add frame button that seems to work in both versions.

MrPrimate commented 1 year ago

Okay, the workflow I expected here would be Add Frame -> Select Another File -> then upload your custom frame to the foundry server.

I will need to make a tweak to accommodate applying the default masking algorithm to files uploaded using the other button.

KellethDregar commented 1 year ago

Ah ok that makes sense, thank you!

KellethDregar commented 11 months ago

Hi @MrPrimate quick question was this tweak ever made to allow masking in this method?

MrPrimate commented 10 months ago

Oh sorry, I made some changes to fix this a while ago but got distracted, please find the final pieces in v4.2.5, available in all good Foundry updaters now.