search

MrPrimate / tokenizer

Tiny yet capable in-game token editor for Foundry VTT
MIT License
29 stars 26 forks source link

Error when opening tokenizer interface #15

Closed laurieathey closed 3 years ago

laurieathey commented 3 years ago

After the fix for number #6 we now get a new error

image Just comes up with that in the console but two errors pop up in-game image and the interface looks like this image until shortly after the error appears the second empty window doesn't exist at all and the UI looks a bit F-ed. It corrects itself to what you can see in the screenshot once it's had the error.

As you can see it doesn't add the frame layer or the mystery-man image.

I can recover from this by adding an image and finding the frame image.

Bosies commented 3 years ago

I have this issue as well where I can't place a portrait for an enemy character, claiming my picture is not of a correct format and that the location where the file is "null" (but it exists).

MrPrimate commented 3 years ago

I'm struggling to replicate this - what is your Avatar/Token upload directory set to? Does this happen on new actors, or is it for existing ones? NPC's/Characters/both? From the scene or from the actors tab?

laurieathey commented 3 years ago

Ok, I'm in the latest of the pathfinder 2e system. Foundry 0.7.9 Fairly sure I'm on latest of your mod, I re-downloaded it when you responded about fixing it.

NPC Sheets I just tried it and replicated the above with actors (Let's call this one Crystal Patch) I've used for games a few weeks ago, so not "new" actors, though I hadn't done anything special with their images since these were for traps.

Tried it with one from AGES ago that did have an image for the token but just mystery man for the artwork. That still threw the "can't find mystery man" error.

tried putting Crystal Patch on a map and opening the token's sheet and editing it, same behaviour. Doesn't seem to matter where I open it.

PC Sheets No errors at all if it's a PC sheet.

Settings image

I've not changed those since installing it again. It might have kept some changes from before? I don't know if mods lose all custom settings from before or if they're cached somewhere and picked back up when you re-install.

EDIT Got a game in an hour but let me know if you need anything else, I'll answer ASAP.

MrPrimate commented 3 years ago

It looks like your on The Forge - can you try selecting an upload directory in your "My Assets Library" it should then look something like: [forgevtt] tokens

laurieathey commented 3 years ago

That was already working with just /tokens but I used the file browser to point it at that folder again, it now says [forgevtt] tokens

I did notice though that the mystery man image (Which I've have never personally set up) was not there. Like that file's location does not exist.

I checked that by going into the prototype token and looking at the image path. if I try to look for that image I see this: image

It actually says "No matching results found in this location". I have no idea what happened honestly but that's likely what is causing the error. The location you can see in the image is not one I EVER touch. I'm not even sure if I can change/add/remove files in that directory. As far as I'm aware that's the default image used.

MrPrimate commented 3 years ago

And just to confirm this is version 2.2.6 of Tokenizer?

laurieathey commented 3 years ago

Yep. Just checked, 2.2.6 image

rrenna commented 3 years ago

Looks like after I updated the upload directory reset to null for me, this was causing similar issues with my setup.

2021-03-01 at 11 24 AM

laquasicinque commented 3 years ago

I found the cause, the next PR should fix it the null issue from occuring and clean it up

laurieathey commented 3 years ago

image

Guessing the PR didn't fix it after all?

laurieathey commented 3 years ago

Shit, that button didn't do what I thought it was gonna do lol

MrPrimate commented 3 years ago

image

It auto closes the issue, but not sure if it's fixed, and the other one was me just not paying attention.

laquasicinque commented 3 years ago

The question is though, has it fixed it for your issues @laurieathey @rrenna and @Bosies

laurieathey commented 3 years ago

Still no update for it on the Forge, I'll check again tonight and see if the update has reached us :)

laurieathey commented 3 years ago

Sorry, I checked for like a day then forgot 😆 I've got the update. So it now throws the errors in game, but recovers and sets the token layers correctly. Bit of a delay in it happening though, dunno if that bothers you or not. It does mean I just need wait ~5 seconds and my token is ready for the usual editing though so I'll take it :)

laquasicinque commented 3 years ago

The only part I could think of that could make it take that long would be loading times as it tries to load a few pictures

laurieathey commented 3 years ago

I'm not sure. It's not breaking it though, and it takes less than time it takes me to navigate to the image of the frame every time so I'm happy with it :)