search

MrPrimate / tokenizer

Tiny yet capable in-game token editor for Foundry VTT
MIT License
29 stars 26 forks source link

Add force-proxy setting #47

Closed filhit closed 3 years ago

filhit commented 3 years ago

If a user hosts their own CORS proxy, they could only proxy requests to a subset of addresses (which the default proxy already handles for everyone). Changing the proxy setting was useless.

This change allows setting your own proxy to fix cors errors as described in #26. If force-proxy setting is set (game.settings.set("vtta-tokenizer", "force-proxy", true), then the proxy is applied to all full urls.

Url changes enable using https://github.com/VTTAssets/image-proxy with a custom access token auth.

filhit commented 3 years ago

If you prefer, I could also move proxy list to a proxy-url-regex setting instead, so you can set it to "^https?://" if you host your own proxy. The default then would be a regex to select https://www.dndbeyond.com, https://dndbeyond.com, and https://media-waterdeep.cursecdn.com.

MrPrimate commented 3 years ago

This is great thanks, I was actually thinking the other day that the current implementation was probably not working.