MrRar / edit_skin

Advanced skin editor mod for Minetest
MIT License
7 stars 5 forks source link

active_block_range affected? #7

Closed animaux closed 1 year ago

animaux commented 1 year ago

After installing edit_skin in minetest 5.6.0 on a server with a game in creative mode, I am not able to reach blocks further away than approximately 3 or 4 blocks. Setting active_block_range on the server doesn’t seem to have any effect.

Though a connection with edit_skin seems unlikely, it was the only thing I changed before this behavior started. Has anybody else noticed something similar?

MrRar commented 1 year ago

edit_skin creates a mesh hand node and puts it in the hand inventory. I guess the mesh hand node is overwriting the range of the default hand even though it does not include a range property (?) I will look into this.

https://github.com/MrRar/edit_skin/blob/6605aafabf54c2f8051b8b3e348fe51d1dee0b78/init.lua#L140

animaux commented 1 year ago

Many thanks, that sound plausible for my uninformed ears ;)

MrRar commented 1 year ago

I fixed the problem of the creative mode hand range not being respected because of edit_skin.

BTW I don't think active_block_range means what you think it does. Here is the description:

The radius of the volume of blocks around every player that is subject to the
active block stuff, stated in mapblocks (16 nodes).
In active blocks objects are loaded and ABMs run.
This is also the minimum range in which active objects (mobs) are maintained.
This should be configured together with active_object_send_range_blocks.

There's no setting in the Minetest game to control the hand range in creative mode. It's always set to 10.

animaux commented 1 year ago

Thanks for fixing this so fast and clarifying! Will try it just now.

animaux commented 1 year ago

Works perfect many thanks!