MrS0m30n3 / youtube-dl-gui

A cross platform front-end GUI of the popular youtube-dl written in wxPython.
The Unlicense
9.27k stars 1.58k forks source link

Accessibility regressions in youtube-dlg 0.4 #202

Open arfy8820 opened 7 years ago

arfy8820 commented 7 years ago

Please follow the guide below

WARNING

All invalid issues will be rejected!!


Before going further


What is the purpose of your issue?

Please remove any sections between (---) if they are not related to your issue


Bug report

If the problem occurs when downloading a URL please provide the full verbose output as follows:

  1. Restart youtube-dl-gui
  2. Go to Options > Extra tab
  3. Enable Debug youtube-dl
  4. Go to Options > Advanced tab and Clear your log content
  5. Try to download the URL
  6. Copy the whole log content and insert it between the ``` part below
delete me and insert your log content here

What operating system do you use ?

Windows 10 Build 1703.

List of actions to perform to reproduce the problem:

  1. Load a screen reader, such as Narrator using control-windows enter in build 1703 or windows-enter in previous builds of windows.
  2. Navigate the main screen using tab and shift tab keys.

What is the expected behaviour ?

The buttons on the main screen should announce with names such as delete button, settings button, etc. This was the behaviour in the previous youtube-dlg, 0.3.8.

What happens instead ?

The screen reader simply says "button" for most buttons on the main screen. This makes it tricky to know what the buttons will do.

MrS0m30n3 commented 7 years ago

That's not exactly a bug, at least not on our side. We use bitmap buttons in version 0.4 so that's probably the reason Narrator can't announce the buttons by name (even though they are labeled).

I'm going to take a closer look on this and see what we can do to improve the accessibility in the next version.

fisher729 commented 7 years ago

Hi.

Regarding this issue. I did speak to you about this the other day. Hope it indeed can be fixed, as this is a great program. For now, though, I use 0.3.8.

tapper82 commented 6 years ago

Hi I am having the same problem using NVDA screen reader. Pleas don't say that it's not a bug when if some one who is blind, cant use your program just because your controls in your UI don't have proper labels. I am willing to help in testing any fixes you mite be able to come up with. Pleas if you don't know how to fix the labels on the buttons, say so and I will ask around to see if any of the blind programmers I know to see if they can help! Thanks. For a blind person this bug really is a show stopper as i cant use this program at all.

tapper82 commented 6 years ago

Any news on this?

tapper82 commented 6 years ago

Ping!

fisher729 commented 6 years ago

I'd suggest you use version 0.3.8 until he sorts it out.

On 10/18/17, tapper82 notifications@github.com wrote:

Ping!

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/MrS0m30n3/youtube-dl-gui/issues/202#issuecomment-337655124

tapper82 commented 6 years ago

version 0.3.8 will not work for me. It says that it's finished downloading but there is no files in the download der.

fisher729 commented 6 years ago

Works fine for me. Have you set download location, file types etc. in the Options dialog?

On 10/25/17, tapper82 notifications@github.com wrote:

version 0.3.8 will not work for me. It says that it's finished downloading but there is no files in the download der.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/MrS0m30n3/youtube-dl-gui/issues/202#issuecomment-339280692

MrS0m30n3 commented 6 years ago

@tapper82

Youtube-dl needs Microsoft's Visual C++ Redistributable package in order to run on Windows. You can download it from here.

chrisnestrud commented 6 years ago

Created PR #252 to add labels to buttons. JAWS 2018 screen reader is able to accurately identify these.

tapper82 commented 6 years ago

after entering the options you cant tab to the OK button with a screenreader.

fisher729 commented 6 years ago

There is no OK button.

On 1/7/18, tapper82 notifications@github.com wrote:

after entering the options you cant tab to the OK button with a screenreader.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/MrS0m30n3/youtube-dl-gui/issues/202#issuecomment-355805984

tapper82 commented 6 years ago

So how do you get out of the window and save your changes? I have never seen a options window before with no OK button!

fisher729 commented 6 years ago

You configure the changes as you go along. There is an option to reset the settings, though. Think Firefox, for example.

On 1/7/18, tapper82 notifications@github.com wrote:

So how do you get out of the window and save your changes? I have never seen a options window before with no OK button!

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/MrS0m30n3/youtube-dl-gui/issues/202#issuecomment-355813790

MrS0m30n3 commented 6 years ago

Just took a look in both version 0.3.8 and 0.4 with Narrator and NVDA. 0.3.8 seems pretty good. 0.4 on the other hand is just bad.

In my opinion you need a new user interface specifically for blind users. We could modify the source code from version 0.3.8 and build on that, 0.4 is just too cluttered.

For the main window we could include:

I would love to hear any suggestions you may have.

chrisnestrud commented 6 years ago

The UI is cluttered, but a lot of UIs are cluttered. I think it would be usable if screen readers are able to identify the buttons and controls. It would also help if controls had accelerator keys (alt+u for URLs, alt+d for downloads, something like that) so it would be easy to jump to a specific control.

This page has suggestions written for Gnome. They should translate to WX. https://developer.gnome.org/accessibility-devel-guide/stable/gad-ui-guidelines.html.en

Simon818 commented 5 years ago

Hi, I just downloaded this to test it for a friend who is not so comfortable fiddling with command line, and was sad to see the label issues. The unfortunate fact is that even if the buttons have labels, they are not in a place that any screen-reader knows how to understand.

I don't agree that we need a "blind interface" at all. If you're worried about clutter we could add access keys such as alt+d for download. These keys would be announced when the user moves to the button, so an attentive user can memorize them. We're used to tabbing through interfaces with several buttons and this is far from the worst thing I've ever seen. It would be usable if everything had a label; it would be great if hotkeys also existed. Don't worry about a separate interface; that's more work on your end and it's almost never a good idea. Thank you for taking a look.