search

MrS0m30n3 / youtube-dl-gui

A cross platform front-end GUI of the popular youtube-dl written in wxPython.
The Unlicense
9.27k stars 1.58k forks source link

Upgrade to wxgtk4.0/python3 #289

Open legrostdg opened 6 years ago

legrostdg commented 6 years ago

It would be nice to convert youtube-dl-gui to use wxgtk4.0, and then to add support for python3!

alexanderluna commented 6 years ago

How do you install wxgtk3.0 ? they only have 4.0 versions.

nodiscc commented 6 years ago

Python3 migration is blocking Debian packaging https://github.com/MrS0m30n3/youtube-dl-gui/issues/21#issuecomment-375959087

h01ger commented 6 years ago

as nodiscc said, not being python3 compatible blocks inclusion in Debian. It's 4-5 months until no new packages cannot be added for Debian "buster" and I'd very much like youtube-dl-gui be included in that release :)

According to sloccount youtube-dl-gui has 4569 lines of python2, how much work will it be to convert it to python3, and how much can be automated and how much is a no-op? ;)

TigerhawkT3 commented 5 years ago

I'm on Python 3.6.0 and I have youtube-dl-gui working. I installed twodict 1.2 with pip install twodict and wxPython 4.0.3 with pip install wxPython. I then downloaded the zipped source of youtube-dl-gui and modified the files so that it works on Python 3. There was some generic Python 2/3 stuff to change (like print syntax), and quite a bit of wxPython stuff. It still gives a deprecation warning for the flag art bitmaps in the BitmapComboBox for language options, but it's only a warning, and I don't see what I'm supposed to use instead anyway.

All I really know how to do in GitHub is commit and push, so I'll need a bit of help with this. How should I go about contributing the Python 3-compatible files?

alexanderluna commented 5 years ago

@TigerhawkT3 You would have to fork this project first, commit your changes to your forked repo and then request a merge.

TigerhawkT3 commented 5 years ago

I was comparing my changed files to the fork I pulled, and I discovered that the zipped source download is 81 commits behind the master branch. I had it working and fixed all the tests, but now I have to go back and add all my changes to the newest version instead.

TigerhawkT3 commented 5 years ago

I've pushed my changes to my fork and requested a merge. Hopefully everything's correct.