search

MrS0m30n3 / youtube-dl-gui

A cross platform front-end GUI of the popular youtube-dl written in wxPython.
The Unlicense
9.27k stars 1.58k forks source link

Make program and test suite compatible with Python 3 instead of 2. #350

Open TigerhawkT3 opened 5 years ago

TigerhawkT3 commented 5 years ago

There are many differences between string handling, hashing, wxPython, etc. in Python 2 and 3, so this breaks compatibility with Python 2. The test suites all succeed, and the program's features appear to work as intended.

phil-hudson commented 5 years ago

+1

maxtron95 commented 3 years ago

@TigerhawkT3 I wanted to ask permission of if I can use this PR in my fork with credit to you.

TigerhawkT3 commented 3 years ago

@TigerhawkT3 I wanted to ask permission of if I can use this PR in my fork with credit to you.

Sure; that's the idea behind open source. :) GitHub must have a built-in way to accomplish it. Since these are two forks of the same original repository, it should just be a merge, described here. I mostly stick to the basics with GitHub, though, so don't take my word for it.

maxtron95 commented 3 years ago

@TigerhawkT3 I'm sorry to bother but, would you be able to create a PR for the fork that I have? It would be simple but, I realized I actually split the repository entirely from the project, or could I commit the code myself and credit you in authors instead.

TigerhawkT3 commented 3 years ago

@TigerhawkT3 I'm sorry to bother but, would you be able to create a PR for the fork that I have? It would be simple but, I realized I actually split the repository entirely from the project, or could I commit the code myself and credit you in authors instead.

It looks like you started your repository today and have only made a few changes to the readme - I'd say it'd be easier and cleaner all around if you make a note of those changes, delete the repo, and just start fresh with a fork of my repo. How does that sound?