MrScautHD / Beyond-Earth

Fly to Other Planets and Beyond!
Other
46 stars 30 forks source link

Desh and Ostrum Ores don't spawn #229

Open ghost opened 1 year ago

ghost commented 1 year ago

Mod loader

Forge

Minecraft version

1.19.2

Beyond Earth version

6.3i

Modloader version

Forge: 43.2.4

The latest.log file

https://gist.github.com/bi-tux/664bc5dd0c8597fbf30ee26ba84a462d#file-minecraft-logs

Issue description

Desh and Ostrum Ores don't spawn on Moon/Mars and structures don't spawn. On Mars, the other Ores (Mars Diamond Ore, etc.) do spawn. On Moon only the Cheese Ore spawns.

Steps to reproduce

  1. Make a MultiMC instance with the minecraft, beyond earth and forge versions listed above
  2. Run it without any further configurations or other mods

Other information

No response

Aleon4201 commented 1 year ago

I see this issue on 6.4b too. And I use the official MC launcher. I play only single-play.

Aleon4201 commented 1 year ago

Additional information I found in your source. Moon Stone is above Y=0, and Deepslate is Y=0~-64. So aboveBottom(32) and aboveBottom(-32) mean Y=-32~-96. There's no Moon Stone there, so some ores aren't spawned I think. Maybe Mars is also.

Btw, I found Diamond and Coal in Venus. I haven't found Redstone yet.

You changed several features including removing each stone tags and item ID from 1.18, so you may should test them again. It's a critical bug that survival players can never go to almost of planets.

Aleon4201 commented 1 year ago

Thanks for hard working. It's the latest list for ores I couldn't find on 6.4c.

Mars Ice Shard Mars Ostrum Mars Diamond Glacio Ice Shard

Mars looks to be changed base stones below y=0 from 1.18. If my memory is right, Mars stone was in all of Mars (~y=-64), but now 1.19, deep underground is filled by deepslate with lush caves. So Mars stone is only in above y=0.

TathanDev commented 1 year ago

Update to 6.4d

Aleon4201 commented 1 year ago

I'll check it because 6.4d isn't uploaded on CurseForge yet.

st0x0ef commented 1 year ago

There is no 6.4d

Aleon4201 commented 1 year ago

Then, what's that TathanDev said?

TathanDev commented 1 year ago

I thought you fix this bug in 6.4d but it was in 6.4c

Aleon4201 commented 1 year ago

I say some ore generations haven't fixed yet in 6.4c. Mainly in Mars including Ostrum (please see a comment above for details). Or, did you re-upload 6.4c again on anywhere? I know only CurseForge for the latest version.