search

MrStandley / i2Website

This is repository for all the i2 Students to build the i2.today Web site.
1 stars 0 forks source link

Fix SHC Logo #2

Open 27achang opened 2 days ago

27achang commented 2 days ago

Issue

Current version of /templates/student-profile.html, Line 17:

<img alt="SHCP Logo" src="/assets/SHC_Logo.png" title="SHCP Website">

Line 17 of the student_profile.html template currently has the image source set to the base directory, which currently fails to render on GitHub pages.

Solution

Summary: Change the reference from an absolute reference (to the base directory) to a relative reference (from the student's student profile directory)
Detailed Solution: Replace /assets/SHC_Logo.png with ../../assets/SHC_Logo.png so that the line reads as follows:

<img alt="SHCP Logo" src="../../assets/SHC_Logo.png" title="SHCP Website">
27achang commented 2 days ago

The i2 icon in the tab has a similar issue, detailed below.

Issue

Current version of /templates/student-profile.html, Line 8:

<link rel="icon" href="/assets/i2_icon_light.gif" sizes="192x192">

Line 8 of the student_profile.html template currently has the image source set to the base directory, which currently fails to render on GitHub pages.

Solution

Summary: Change the reference from an absolute reference (to the base directory) to a relative reference (from the student's student profile directory)
Detailed Solution: Replace /assets/i2_icon_light.gif with ../../assets/i2_icon_light.gif so that the line reads as follows:

<link rel="icon" href="../../assets/i2_icon_light.gif" sizes="192x192">
27achang commented 2 days ago

The template in update-student-profile solves this issue (link).